Merged
Conversation
Collaborator
|
There seems to be some gf_* removal that can also be done in depend.common. |
weiwangncar
approved these changes
Mar 6, 2026
dudhia
previously approved these changes
Mar 11, 2026
Collaborator
dudhia
left a comment
dudhia
left a comment
There was a problem hiding this comment.
Conditional on regression tests completing.
weiwangncar
previously approved these changes
Mar 13, 2026
Collaborator
Author
|
@weiwangncar Do you know if either of these files triggers the Scala tests? It seems like it won't |
Collaborator
|
@islas It doesn't look like the changes triggered a re-test. Let's force it for a test by adding 'Retest' label. I see that you added 'Retest' yesterday. But I didn't receive any output from the test. |
Collaborator
Author
|
@weiwangncar I did that yesterday, but no luck |
Collaborator
|
@islas Maybe changes in depend.common is excluded from the test? But in the meantime, you may need to add a trivial change in one of the .F files to trigger a test. |
dudhia
approved these changes
Mar 16, 2026
Collaborator
Author
|
@weiwangncar Could you take a look at this? I'd prefer this go in before #2290 |
weiwangncar
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bugfix
KEYWORDS: build, make, cmake
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
PR #2269 introduced the GFL submodule replacing the older GF implementation. In doing so, the related files' dependencies and additions to both builds was not done completely.
Solution:
Add object dependencies for make build. Remove old file reference and update with new files in cmake build.